Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RandomApply and RandomChoice #20727

Open
innat opened this issue Jan 5, 2025 · 5 comments
Open

add RandomApply and RandomChoice #20727

innat opened this issue Jan 5, 2025 · 5 comments
Assignees
Labels
type:feature The user is asking for a new feature.

Comments

@innat
Copy link

innat commented Jan 5, 2025

This was included in keras-cv.

@mehtamansi29 mehtamansi29 added the type:support User is asking for help / asking an implementation question. Stackoverflow would be better suited. label Jan 8, 2025
@mehtamansi29
Copy link
Collaborator

Hi @innat -

Can you elaborate the issue which you are facing with more details ?

@innat
Copy link
Author

innat commented Jan 8, 2025

I believe the two layers mentioned above haven't been moved from keras-cv to keras, but they should be.

@hertschuh
Copy link
Collaborator

I believe the two layers mentioned above haven't been moved from keras-cv to keras, but they should be.

Hi @innat , correct they should be moved to keras. This work still needs to be done.

@harshaljanjani
Copy link
Contributor

harshaljanjani commented Jan 12, 2025

Hi!
Would love to contribute here if this task is up for the taking. I noticed in #434 a comment mentioning that RandomChoice is currently under the keras_cv.layers.preprocessing module, and it seems RandomApply is there as well. While they’re not strictly preprocessing layers, when moving them, would they still go under layers.preprocessing?
Edit: I'm currently working on RandomChoice and have successfully integrated RandomApply with unit tests. I will raise a PR soon!

@harshaljanjani
Copy link
Contributor

Hey!
Just wanted to mention that this PR might require an API modification, so a modification of the labels in the issue thread would be much appreciated. Thanks!

@hertschuh hertschuh added type:feature The user is asking for a new feature. and removed type:support User is asking for help / asking an implementation question. Stackoverflow would be better suited. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants