Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matching end of entity and end of architecture #13

Open
m-tosch opened this issue Mar 17, 2019 · 1 comment · May be fixed by #14
Open

matching end of entity and end of architecture #13

m-tosch opened this issue Mar 17, 2019 · 1 comment · May be fixed by #14

Comments

@m-tosch
Copy link

m-tosch commented Mar 17, 2019 •
edited
Loading

Entities and architectures can end with "end some_name;" instead of "end entity;" or "end architecture;" The regex should check for any word (maybe with \w) instead of the specific keywords "entity" and "architecture"

hdlparse/hdlparse/vhdl_parser.py

Line 87 in be7cdab

(r'end\s+entity\s*;', 'end_entity', '#pop'),

hdlparse/hdlparse/vhdl_parser.py

Line 92 in be7cdab

(r'end\s+architecture\s*;', 'end_arch', '#pop'),

@andresmanelli andresmanelli linked a pull request Jul 11, 2019 that will close this issue
Open
@m-tosch
Copy link
Author

m-tosch commented May 18, 2020

The same is also true for

package
The same is true for packages. They can also end with "end some_name;" instead of "end package;"

hdlparse/hdlparse/vhdl_parser.py

Line 35 in be7cdab

(r'end\s+package', None, '#pop'),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add entity parsing andresmanelli/hdlparse
1 participant
@m-tosch