Channel/Thread Chat Toggle #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 21, 2024
JT2M0L3Y
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
Should be suitable for users looking to choose between use of a channel and a separate thread.
I see no glaring issues with existing comments or fixes.
Nice to see the jsonHandler method starting to get more rounded out. Looking ahead, this has a potential to be reasonably coupled with future caching features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
build.ymlfiles will run on PR now to make sure the build is fine prior to merging into the master branch.path:on what constitutes as change for running the tests.Screenshots
GuildText stored histories (without user preferences yet, that relies on a different feature -> #36)
Toggle working
