Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: share the footer code between sites. #390

Open
mcdurdin opened this issue Sep 28, 2023 · 1 comment
Open

chore: share the footer code between sites. #390

mcdurdin opened this issue Sep 28, 2023 · 1 comment
Assignees
@mcdurdin
Labels
chore
Milestone
19.0

Comments

@mcdurdin
Copy link
Member

TODO: share the footer code between sites.

Originally posted by @mcdurdin in #388 (comment)

The common footer should be available to help.keyman.com, keyman.com, keymanweb.com. This will be easier to achieve once we have the shared code in keymanapp/help.keyman.com#389 done on all sites.
@mcdurdin mcdurdin added the chore label Sep 28, 2023
@mcdurdin mcdurdin added this to the A17S25 milestone Sep 28, 2023
@mcdurdin mcdurdin self-assigned this Sep 28, 2023
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
@darcywong00 darcywong00 modified the milestones: A17S26, A17S27 Nov 27, 2023
@darcywong00
Copy link
Contributor

One of the wrinkles is each site would have a unique getPageUrlForEditLink()

@mcdurdin mcdurdin modified the milestones: A17S27, A17S28, A17S30 Dec 8, 2023
@mcdurdin mcdurdin modified the milestones: A17S30, 18.0 Jan 11, 2024
@mcdurdin mcdurdin modified the milestones: 18.0, 19.0 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore
Projects
None yet
Milestone
19.0
Development

No branches or pull requests
2 participants
@mcdurdin @darcywong00