Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Modify stable url for keyboard download to exe and js files #495

Open
darcywong00 opened this issue Nov 4, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@darcywong00
Copy link
Contributor

From review comment #475 (review) for addressing #474

Hmm, is this (.htaccess) a much older bug, not actually coming out of the Apache/docker transition? Let's make sure we get it right for all patterns. The bundled installer .exe is now actually not a "bundle" but a file name pattern which causes the bundle to download (see https://kmn.sh/kb35, keyman-setup filename patterns section), so we may need to do some more work to get that right.

TODO:

@darcywong00 darcywong00 added this to the A18S14 milestone Nov 4, 2024
@mcdurdin mcdurdin changed the title fix: Modify stable url for keyboard download to exe and js files bug: Modify stable url for keyboard download to exe and js files Nov 4, 2024
@mcdurdin mcdurdin added the bug Something isn't working label Nov 4, 2024
@darcywong00 darcywong00 modified the milestones: A18S14, A18S15 Nov 9, 2024
@darcywong00 darcywong00 modified the milestones: A18S15, A18S16 Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants