Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seo): add meta keywords for supported languages #502

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(seo): add meta keywords for supported languages #502

wants to merge 2 commits into from
+26 −2

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 23, 2024

  • keyboard-details.php: use the langauge name(s) to produce keyboards.
  • template.php: support 'keywords' to pass to head()
  • Head.php: to support keywords as a parameter to head(), rendered as a meta tag. Escape ASCII quotes properly as entities.

Note

This is a little contrived, but showing that the machinery is quoting properly, if the
keywords had the text Some "information" for <you>:

<meta name="keywords" content="Some &quot;information&quot; for <you>, Amharic Keyboard, Basketo Keyboard, Bench Keyboard, Dirasha Keyboard, Dizin Keyboard, Geez Keyboard, Gumuz Keyboard, Konso Keyboard, Suri, Tirmaga-Chai Keyboard, Tigré Keyboard, Zayse Keyboard, Multiple languages Keyboard">

yielding (showing proper unescaping)

> document.getElementsByTagName('meta')[1].getAttribute('content')
'Some "information" for <you>, Amharic Keyboard, Basketo Keyboard, Bench Keyboard, Dirasha Keyboard, Dizin Keyboard, Geez Keyboard, Gumuz Keyboard, Konso Keyboard, Suri, Tirmaga-Chai Keyboard, Tigré Keyboard, Zayse Keyboard, Multiple languages Keyboard'

@srl295
feat(seo): add meta keywords for supported languages
03b3351 
- keyboard-details.php: use the langauge name(s) to produce keyboards.
- template.php: support 'keywords' to pass to head()
- Head.php: to support keywords as a parameter to head(), rendered as a meta tag. Escape ASCII quotes properly as entities.
@darcywong00 darcywong00 added this to the A18S16 milestone Nov 25, 2024
@darcywong00 darcywong00 mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 Awaiting requested review from darcywong00

@mcdurdin mcdurdin Awaiting requested review from mcdurdin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
A18S16
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @darcywong00