Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency error and delay in low level hook #15

Open
OliBomby opened this issue Aug 23, 2023 · 1 comment
Open

Concurrency error and delay in low level hook #15

OliBomby opened this issue Aug 23, 2023 · 1 comment

Comments

@OliBomby
Copy link
Contributor

I use your library in my application to handle various keybinds. At times people report large input delay on they keypresses while my application is open. This must be because of the low level keyboard hook being slow, which makes it quite invasive.

I managed to capture this exception in the lower level hook by accident when I was debugging my application. This looks pretty serious and such exceptions could be the cause of the occasional input delay. Due to the ephemeral nature of the bug, I can't provide good reproduction steps. I think it happened while I was typing something.

image

It's interesting that the modifier keys have a lock to provide exclusive access to the hash set. Why does the keys hashset not utilize a lock?

@AlexVirlan
Copy link

I think that this might be solved by using another lock on that variable. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants