feat: share external dependencies between micro-frontends (rxjs + single-spa) #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables sharing of external dependencies between micro-frontends.
NOTE:
At this moment, Vite adds
/@id/
in front of dependencies that were marked as external. This breaks theimport
statements during dev mode. Since Angular provides no way to hook into the Vite config, I have added a patch file on the@angular/build
package to work around this. My next step will be to open a new issue on the angular-cli repo and submit a PR to (hopefully) integrate a fix upstream.Related issues on Vite repo:
=> When we have access to the Vite config, it can be solved by using a plugin (https://github.com/MilanKovacic/vite-plugin-externalize-dependencies) but as mentioned before, this is currently not possible with the Angular application builder (and likely never will be)
Somewhat related earlier PR on angular-cli repo: (which acknowledges that the issue is not really fixed...)
angular/angular-cli#26129