Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize config for binary & controller #10679

Open
lgadban opened this issue Feb 21, 2025 · 0 comments
Open

Standardize config for binary & controller #10679

lgadban opened this issue Feb 21, 2025 · 0 comments
Milestone

Comments

@lgadban
Copy link
Contributor

lgadban commented Feb 21, 2025

Existing "settings" processing is explicitly done via env vars, ref: https://github.com/kgateway-dev/kgateway/blob/main/internal/kgateway/extensions2/settings/settings.go#L7-L12

This was intended to be as lightweight as possible while still providing a standardized approach.

The controller binary is now ran via cobra and contains explicit CLI flags as well.

We should consolidate and standardize on way to configure kgateway so we don't have different ways to accomplish the same thing.

This may lead us to refactor the setup package that the cmd kgateway main package calls to make it easier to plumb configuration from flags || envvars. ~ useful context from @timflannagan

We will also need to consider the helm API for these settings/config -- not all config should be exposed via Helm API IMO

Possible Options:

  • Viper is fairly idiomatic and allows to define configuration in a single place and demotes the env-var specifics to an implementation detail.
  • Use Viper but defer config to CM that is mounted in kgateway
@lgadban lgadban added this to the kgw 2nd cut milestone Feb 21, 2025
@lgadban lgadban moved this from Backlog to Planned in Kgateway Planning Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

1 participant