Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS Unsupported #180

Open
Silberling opened this issue Mar 27, 2021 · 0 comments
Open

HTTPS Unsupported #180

Silberling opened this issue Mar 27, 2021 · 0 comments

Comments

@Silberling
Copy link

Hi.

I have a local CA and DNS and switched to HTTPS on my OSMC Vero yesterday (no proxy for this device).

Now on my Windows computer I selected

Host: osmc.mynetwork Port: 443

And got

Unable to connect to Kodi

I also tried prepending https:// but it doesn't help.

Accessing The WebInterface (Chorus) works just file, Local CA installed so the Website shows it is ok.

I can't find any configuration regarding SSL in the plugin.

I tried curl -i -X POST -d '{"jsonrpc": "2.0", "method": "Player.Open", "params": {"item": { "file" : "plugin://plugin.video.youtube/play/?video_id=ABCXYZWHATEVER"}}, "id": 1}' https://osmc.mynetwork/jsonrpc -H "Content-Type: application/json"

-> Works fine

So I skipped through the code and found in shared.js:56 getURL() that you prefix the URL with http:// without the possibility of using SSL.

So I'd like to ask kindly to update the public version if this plugin to support HTTPS.

I'd be satisfied even if it would be a small dirty fix like

if (!url.startsWith("https://")) { url = 'http://' + url; }

Awesome would be a dropdown of procotols in front of the URL which defaults to HTTP but allows https.

But I'd really appreciate of you could push at least this small fix to the chrome web store so I can go back using this really awesome and in this household much used plugin.

You are great!
Have a really awesome weekend and stay healthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant