Skip to content

Commit

Permalink
updates
Browse files Browse the repository at this point in the history
Signed-off-by: Kial Jinnah <[email protected]>
  • Loading branch information
kialj876 committed Jun 6, 2024
1 parent 93eb87f commit a4869b0
Show file tree
Hide file tree
Showing 9 changed files with 2,356 additions and 16,822 deletions.
75 changes: 40 additions & 35 deletions .github/workflows/search-ui-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
if: github.repository == 'bcgov/registries-search'

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: "true"

linting:
Expand All @@ -27,55 +27,60 @@ jobs:

strategy:
matrix:
node-version: [20.6.1]
node-version: [20]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version: ${{ matrix.node }}

- name: Install dependencies
run: |
make setup
- name: Linting
run: |
make lint
- run: npm install

- name: Lint
- run: npm run lint

testing-coverage:
unit-testing:
needs: setup-job
runs-on: ubuntu-20.04

strategy:
matrix:
node-version: [20.6.1]
node-version: [20]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install dependencies
run: |
make setup
- name: Test with Jest
id: test
run: |
make test
# - name: Upload coverage to Codecov
# uses: codecov/codecov-action@v3
# with:
# name: codecov-search-ui
# fail_ci_if_error: true
steps:
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

- name: Install dependencies
- run: npm install

- name: Test
- run: npm run test:unit

build-check:
needs: setup-job
runs-on: ubuntu-20.04

strategy:
matrix:
node-version: [20]

steps:
- uses: actions/checkout@v3
- name: build to check strictness
id: build
run: |
make build-nc
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

- name: Install dependencies
- run: npm install

- name: Build
- run: npm run build
2 changes: 1 addition & 1 deletion search-ui/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = {
'warn',
{ code: 120, ignoreRegExpLiterals: true, ignoreTrailingComments: true },
],
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
"no-console": ["error", { "allow": ["warn", "error", "info"] }],
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'@typescript-eslint/no-explicit-any': 'off',
// 'prettier/prettier': [
Expand Down
23 changes: 0 additions & 23 deletions search-ui/Dockerfile

This file was deleted.

84 changes: 0 additions & 84 deletions search-ui/Makefile

This file was deleted.

Loading

0 comments on commit a4869b0

Please sign in to comment.