MBL-1661 & MBL-1666: Red notification dot in top right corner of PPO …

…tier 1 alert cards & Remove unused composables (#2101)
kickstarter · Aug 19, 2024 · 32bbf87 · 32bbf87
1 parent f87255a
commit 32bbf87
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 317 deletions.
diff --git a/app/src/main/graphql/pledgeProjectsOverview.graphql b/app/src/main/graphql/pledgeProjectsOverview.graphql
@@ -9,7 +9,6 @@ query PledgedProjectsOverview($first: Int, $after: String, $last: Int, $before:
                 ...ppoCard
                 }
                 tierType
-                tags
             }
           }
           pageInfo {

diff --git a/app/src/main/java/com/kickstarter/features/pledgedprojectsoverview/data/PPOCard.kt b/app/src/main/java/com/kickstarter/features/pledgedprojectsoverview/data/PPOCard.kt
@@ -21,7 +21,6 @@ class PPOCard private constructor(
     val imageContentDescription: String?,
     val creatorName: String?,
     val backingDetailsUrl: String?,
-    val showBadge: Boolean,
     val timeNumberForAction: Int,
     val viewType: PPOCardViewType?
 
@@ -41,7 +40,6 @@ class PPOCard private constructor(
     fun imageContentDescription() = this.imageContentDescription
     fun creatorName() = this.creatorName
     fun backingDetailsUrl() = this.backingDetailsUrl
-    fun showBadge() = this.showBadge
     fun timeNumberForAction() = this.timeNumberForAction
     fun viewType() = this.viewType
 
@@ -61,7 +59,6 @@ class PPOCard private constructor(
         var imageContentDescription: String? = null,
         var creatorName: String? = null,
         var backingDetailsUrl: String? = null,
-        var showBadge: Boolean = false,
         var timeNumberForAction: Int = 0,
         var viewType: PPOCardViewType? = null,
     ) : Parcelable {
@@ -81,7 +78,6 @@ class PPOCard private constructor(
         fun creatorName(creatorName: String?) = apply { this.creatorName = creatorName }
         fun backingDetailsUrl(backingDetailsUrl: String?) = apply { this.backingDetailsUrl = backingDetailsUrl }
         fun timeNumberForAction(timeNumberForAction: Int) = apply { this.timeNumberForAction = timeNumberForAction }
-        fun showBadge(showBadge: Boolean) = apply { this.showBadge = showBadge }
         fun viewType(viewType: PPOCardViewType?) = apply { this.viewType = viewType }
 
         fun build() = PPOCard(
@@ -99,7 +95,6 @@ class PPOCard private constructor(
             imageContentDescription = imageUrl,
             creatorName = creatorName,
             backingDetailsUrl = backingDetailsUrl,
-            showBadge = showBadge,
             timeNumberForAction = timeNumberForAction,
             viewType = viewType,
         )
@@ -120,7 +115,6 @@ class PPOCard private constructor(
         imageContentDescription = imageContentDescription,
         creatorName = creatorName,
         backingDetailsUrl = backingDetailsUrl,
-        showBadge = showBadge,
         timeNumberForAction = timeNumberForAction,
         viewType = viewType,
     )
@@ -147,7 +141,6 @@ class PPOCard private constructor(
                 imageUrl() == other.imageUrl() &&
                 imageContentDescription() == other.imageContentDescription() &&
                 backingDetailsUrl() == other.backingDetailsUrl() &&
-                showBadge() == other.showBadge() &&
                 timeNumberForAction() == other.timeNumberForAction() &&
                 viewType() == other.viewType()
         }

diff --git a/app/src/main/java/com/kickstarter/features/pledgedprojectsoverview/data/PPOCardFactory.kt b/app/src/main/java/com/kickstarter/features/pledgedprojectsoverview/data/PPOCardFactory.kt
@@ -20,7 +20,6 @@ class PPOCardFactory private constructor() {
             creatorName: String?,
             backingDetailsUrl: String?,
             timeNumberForAction: Int,
-            showBadge: Boolean,
             viewType: PPOCardViewType?
         ): PPOCard {
             return PPOCard.builder()
@@ -38,7 +37,6 @@ class PPOCardFactory private constructor() {
                 .backingDetailsUrl(backingDetailsUrl)
                 .viewType(viewType)
                 .timeNumberForAction(timeNumberForAction)
-                .showBadge(showBadge)
                 .build()
         }
 
@@ -57,7 +55,6 @@ class PPOCardFactory private constructor() {
                 creatorName = "creatorName",
                 backingDetailsUrl = "backing/details/url",
                 timeNumberForAction = 10,
-                showBadge = false,
                 viewType = PPOCardViewType.CONFIRM_ADDRESS
             )
         }
@@ -77,7 +74,6 @@ class PPOCardFactory private constructor() {
                 creatorName = "Creator Name",
                 backingDetailsUrl = "backing/details/url",
                 timeNumberForAction = 7,
-                showBadge = false,
                 viewType = PPOCardViewType.FIX_PAYMENT
             )
         }
@@ -98,7 +94,6 @@ class PPOCardFactory private constructor() {
                 creatorName = "Creator Name",
                 backingDetailsUrl = "backing/details/url",
                 timeNumberForAction = 7,
-                showBadge = false,
                 viewType = PPOCardViewType.AUTHENTICATE_CARD
             )
         }
-Original file line number
+Diff line change
@@ Expand Up @@
                     ...ppoCard
                     }
                     tierType
-                    tags
                 }
               }
               pageInfo {
@@ Expand Down @@