Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order for steps about how to create a multi-tier system #535

Open
rjrpaz opened this issue Jan 31, 2024 · 3 comments
Open

Wrong order for steps about how to create a multi-tier system #535

rjrpaz opened this issue Jan 31, 2024 · 3 comments
Assignees

Comments

@rjrpaz
Copy link
Contributor

rjrpaz commented Jan 31, 2024

This is regarding: https://docs.killbill.io/latest/how-to-set-up-a-multi-tier-system

Steps to install a multi-tier seems to be fine according to the index. However the content does not follow the same order. As an example, Step 3 describes how to create two databases from an instance that is created in Step 5.

@rjrpaz
Copy link
Contributor Author

rjrpaz commented Feb 2, 2024

Also, both database schemas has the same name ("ddl.sql"). In the next step the tutorial refers to "killbill.ddl" and "kaui.ddl". I think is best to keep different names for each schema. I used "wget" instead of sftp to download schemas and having the same name was confusing.

The link to the 2nd schema is wrong. It should be: https://raw.githubusercontent.com/killbill/killbill-admin-ui/master/db/ddl.sql

The command to import the schemas does not include the database name. It should be something like this:

mysql -h<DB-Endpoint-Writer-Instance> -u<DB-Username> -p<DB-Password> kilbill < killbill.ddl
mysql -h<DB-Endpoint-Writer-Instance> -u<DB-Username> -p<DB-Password> kaui < kaui.ddl

instead of:

mysql -h<DB-Endpoint-Writer-Instance> -u<DB-Username> -p<DB-Password> < killbill.ddl
mysql -h<DB-Endpoint-Writer-Instance> -u<DB-Username> -p<DB-Password> < kaui.ddl

It's also not recommended to include "DB-Password" as part of the command because shell history will store that information.

@sbrossie
Copy link
Member

sbrossie commented Feb 2, 2024

@vnandwana Could you review?

@vnandwana
Copy link
Contributor

  1. The linking of steps is not in sync with actual content.

  2. I'm okay with renaming "ddl.sql" to KB or Kaui specific name, its just that customer can name their database whatever they want -- this is why USE killbill command is commented in the ddl.sql.

  3. Regarding the DB password, I agree we should not include it directly in the command-line argument, we can instead just use the -p option, and MySQL will prompt for the password interactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants