Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle warden throw error when using ActionController::Live #21

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Handle warden throw error when using ActionController::Live #21

merged 1 commit into from
Dec 23, 2024

Conversation

tungleduyxyz
Copy link
Contributor

@tungleduyxyz tungleduyxyz requested a review from pierre June 9, 2024 03:57
pierre
pierre reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@pierre pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in engine_controller instead, so that it's available for all controllers?

Also, this change is probably required in all mountable engines? If you agree, can you make the change?

@pierre pierre merged commit 1ebf8dd into killbill:master Dec 23, 2024
1 check passed
@tungleduyxyz
Copy link
Contributor Author

This issue happens with KPM only.
This exception comes from ActionController::Live, we use it to streaming logs.
For the other plugin, we issue handled by devise gem. So I think we dont need to add the rescue for all the plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierre pierre pierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tungleduyxyz @pierre