You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried to update slf4j version manually to 2.0.2 in killbill repository. There's compile error with TestingLoggingHelper, but I checked that it is not used anywhere in the killbill repository, so I delete it.
I ran build with fast and slow profile and seems like everything Ok. I have branch with slf4j removed from dependabot.yml, but I think this wouldn't pass until we delete TestLoggingHelper first.
You might want to create a PR here with the slf4j update, to see if really all the builds from all repos pass. I'm surprised mvn verify didn't throw any error as a lot of libraries were still relying on 1.x AFAIK.
We've had to ignore some libraries updates over the years due to various upstream blockers, see
killbill-oss-parent/.github/dependabot.yml
Line 9 in 9c3d97f
Once the various pending PRs from dependabot have been merged, let's do a 2022 pass, to see if some of these ignore entries can be removed.
The text was updated successfully, but these errors were encountered: