Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 2022 dependabot configuration #557

Open
pierre opened this issue Sep 14, 2022 · 2 comments
Open

Review 2022 dependabot configuration #557

pierre opened this issue Sep 14, 2022 · 2 comments
Assignees

Comments

@pierre
Copy link
Member

pierre commented Sep 14, 2022

We've had to ignore some libraries updates over the years due to various upstream blockers, see

Once the various pending PRs from dependabot have been merged, let's do a 2022 pass, to see if some of these ignore entries can be removed.

@xsalefter
Copy link
Contributor

xsalefter commented Sep 26, 2022

SLF4J 2.0.2

I tried to update slf4j version manually to 2.0.2 in killbill repository. There's compile error with TestingLoggingHelper, but I checked that it is not used anywhere in the killbill repository, so I delete it.

I ran build with fast and slow profile and seems like everything Ok. I have branch with slf4j removed from dependabot.yml, but I think this wouldn't pass until we delete TestLoggingHelper first.

@pierre WDYT?

@pierre
Copy link
Member Author

pierre commented Sep 27, 2022

You might want to create a PR here with the slf4j update, to see if really all the builds from all repos pass. I'm surprised mvn verify didn't throw any error as a lot of libraries were still relying on 1.x AFAIK.

Looks like TestLoggingHelper is quite old and @andrenpaes refactored @holkra's tests in killbill/killbill@cda33db. 👍 to delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants