Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Rollup with ESBuild in the skeleton boilerplate #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aendra-rininsland
Copy link

Fixes #72.

Copy link

@hughsk-canva hughsk-canva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aendra-rininsland! Very happy to switch this over. Will get this published once it's merged in the internal repo :)

@hughsk-canva
Copy link

Ah wait, having tested this on a few templates it looks like esbuild's output isn't as small as rollup's — on one of our larger templates we had 976kB with esbuild, and 868kB with rollup + terser.

Because of the size difference we're going to continue to use rollup internally for at least some of our templates. I'm a bit more on the fence between the two tools with that in mind, but still really like that esbuild works so well out of the box for most modern projects. If not esbuild, then an update of the rollup boilerplate is definitely still in order!

Though it's not reflected in the SDK boilerplate, we currently use rollup --watch in combination with build.src.watch in template.yml for incremental builds, and disable babel/terser in development. With that we get ~2s for an incremental build on our largest template, which would otherwise be 32s if it were using the boilerplate. Not as fast as esbuild for sure, but still manageable :')

Unfortunately I'm about to go on break for a few weeks and won't be able to get an update through in time, but will think it through and let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Rollup with ESBuild
2 participants