Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning visualization feature not working in scatter/data magic templates #83

Open
h-robertson opened this issue Jun 17, 2022 · 3 comments

Comments

@h-robertson
Copy link
Contributor

When you try and use the cloning viz feature in the SDK (e.g. adding the ID of this scatter visualization when running the scatter template) it doesn't seem to work anymore.

I'm not 100% sure if it's the data magicness that's preventing this, but I also tried one in the Table template (also a data magic one) and it doesn't work there anymore either.

Here's the errors from the console in Scatter:
image

@daanlouter
Copy link

Interesting.. I wonder if this is because it doesn't send the data magic metadata object? Does that sound reasonable, @oampo?

@oampo
Copy link
Contributor

oampo commented Jun 20, 2022

Yep, it looks like both getLiveApiOptionsObject and getPublishedJsonObject in server/entity/private/visualisation/serializer.js need updating to also include the metadata.

@oampo
Copy link
Contributor

oampo commented Jun 20, 2022

I think @bobbysebolao did the SDK changes to add metadata, so probably has more context than me on how the everything works there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants