From b34ecc3e6a763f754d3955591677003d7959ed43 Mon Sep 17 00:00:00 2001 From: Backnol Yogendran Date: Wed, 7 Oct 2015 09:59:54 -0400 Subject: [PATCH] Move DOM manipulation to the link function of the appropriate directive. --- angularjs-datetime-picker.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/angularjs-datetime-picker.js b/angularjs-datetime-picker.js index 469d755..2f31a40 100644 --- a/angularjs-datetime-picker.js +++ b/angularjs-datetime-picker.js @@ -60,11 +60,6 @@ datetimePickerEl = $compile(div)(options.scope)[0]; datetimePickerEl.triggerEl = options.triggerEl; - // Hide the time selection if dateOnly is not set. - if (options.dateOnly === '' || options.dateOnly === true){ - datetimePickerEl.querySelector('#adp-time').style.display = 'none'; - } - $document[0].body.appendChild(datetimePickerEl); //show datetimePicker below triggerEl @@ -183,6 +178,10 @@ scope.inputHour; scope.inputMinute; + if (scope.dateOnly === true){ + element[0].querySelector('#adp-time').style.display = 'none'; + } + scope.$applyAsync( function() { ctrl.triggerEl = angular.element(element[0].triggerEl); if (attrs.ngModel) { // need to parse date string