Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python3.8 for llama-index-packs #52

Open
seyeong-han opened this issue Jun 21, 2024 · 1 comment · May be fixed by #53
Open

Support Python3.8 for llama-index-packs #52

seyeong-han opened this issue Jun 21, 2024 · 1 comment · May be fixed by #53
Assignees
@kevinl424 @seyeong-han
Labels
help wanted Extra attention is needed

Comments

@seyeong-han
Copy link
Collaborator

To integrate our code into the llama-index, we need to support Python3.8, which was not our option.

The main fix points will be adding manual typing, which was first implemented in Python 3.9.
@seyeong-han seyeong-han added the help wanted Extra attention is needed label Jun 21, 2024
@kevinl424
Copy link
Collaborator

I see, I thought that typing was introduced in Python 3.5? What do you mean by manual typing here?

@seyeong-han seyeong-han linked a pull request Jun 21, 2024 that will close this issue
[REFACTOR][HOTFIX] 52 support python38 for llama index packs #53
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinl424 kevinl424

@seyeong-han seyeong-han

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REFACTOR][HOTFIX] 52 support python38 for llama index packs kingjulio8238/Memary
2 participants
@kevinl424 @seyeong-han