Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added serialization interfaces for DateOnly, TimeOnly, Guid and Duration #8

Merged
merged 14 commits into from
Feb 14, 2024
Merged

Added serialization interfaces for DateOnly, TimeOnly, Guid and Duration #8

merged 14 commits into from
Feb 14, 2024

Conversation

ricardoboss
Copy link
Member

@ricardoboss ricardoboss commented Feb 9, 2024 •
edited
Loading

This fixes #1.

Things to do:

  • Add implementations for DateOnly and TimeOnly
  • Add Duration serialization

In the end, I didn't use time_machine because of two reasons: 1. it's another dependency, and 2. the implementation is very simple.

@ricardoboss ricardoboss marked this pull request as ready for review February 12, 2024 15:38
@ricardoboss ricardoboss changed the title Added DateOnly and TimeOnly interfaces Added DateOnly and TimeOnly and serializations for Guid and Duration Feb 12, 2024
baywet
baywet reviewed Feb 12, 2024
View reviewed changes
lib/src/date_only_impl.dart Outdated Show resolved Hide resolved
@ricardoboss ricardoboss changed the title Added DateOnly and TimeOnly and serializations for Guid and Duration Added serialization interfaces for DateOnly, TimeOnly, Guid and Duration Feb 12, 2024
baywet
baywet reviewed Feb 13, 2024
View reviewed changes
lib/src/date_only.dart Show resolved Hide resolved
lib/src/date_only.dart Show resolved Hide resolved
andrueastman
andrueastman approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ricardoboss ricardoboss merged commit 5d52216 into main Feb 14, 2024
1 check passed
@ricardoboss ricardoboss deleted the issues/1-missing-data-types branch February 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet left review comments

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Parsable interface is missing data types
3 participants
@ricardoboss @andrueastman @baywet