Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in NetworkSettingsWidget::updateInformation #111

Open
bmcdorman opened this issue Jan 6, 2023 · 3 comments
Open

Bug in NetworkSettingsWidget::updateInformation #111

bmcdorman opened this issue Jan 6, 2023 · 3 comments

Comments

@bmcdorman
Copy link
Member

bmcdorman commented Jan 6, 2023

The following bug exists in NetworkSettingsWidget. connectionModeSelect needs to be updated first before this check. A fix (55fdc58) was implemented that complicates botui's RootController. This fix needs to be removed and the underlying bug corrected in the erinQt6Branch.

if (ui->connectionModeSelect->currentText() == "Client Mode") // if Wombat in client mode

@chrehall68
Copy link
Contributor

The fix you mentioned was removed in eab3ad8.

@chrehall68
Copy link
Contributor

However, the underlying logic of checking the connectionModeSelect button remained in erinQt6Upgrade, causing #130 . This is now fixed in #131

@chrehall68
Copy link
Contributor

Both the line and the underlying logic have been fixed, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants