Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label not get label or singularLabel from Nova Resource #128

Open
xpalacinengelsolar opened this issue Feb 14, 2024 · 1 comment
Open

Label not get label or singularLabel from Nova Resource #128

xpalacinengelsolar opened this issue Feb 14, 2024 · 1 comment

Comments

@xpalacinengelsolar
Copy link

xpalacinengelsolar commented Feb 14, 2024

Good morning,

Label not get label or singularLabel from Nova Resource, get name of HasMany passed, my code:

HasMany::make('Direcciones', 'dealer_addresses', DealerAddress::class)
    ->sortable(),

The label displayed is 'Direcciones' but in inline items show 'Direccione' and the label of label or singularLabel not my resource code:

    /**
     * Get the displayable label of the resource.
     *
     * @return string
     */
    public static function label()
    {
        return __('Direcciones del dealer');
    }

    /**
     * Get the displayable singular label of the resource.
     *
     * @return string
     */
    public static function singularLabel()
    {
        return __('Dirección del dealer');
    }

I expect in items inline label the singularLabel() value 'Dirección del dealer'

If on the contrary use simple has many make:

HasMany::make('dealerAddresses')
    ->inline(),

The label displayed is 'dealer_addresses' but in inline items show 'Dealer_address' and I expect in label the value of label method 'Direcciones del dealer' and in items inline label the singularLabel() value 'Dirección del dealer'.

I have installed versions:

"kirschbaum-development/nova-inline-relationship": "^2.1" // 2.1.1
 "laravel/framework": "^10.0", // 10.13.0
"laravel/nova": "~4.0", // 4.24.4

Thanks

@luisdalmolin
Copy link
Member

@xpalacinengelsolar We are not currently actively maintaining this project, but we are open to pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants