Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels shows as array #42

Open
nemrutco opened this issue Jan 16, 2020 · 42 comments
Open

Labels shows as array #42

nemrutco opened this issue Jan 16, 2020 · 42 comments
Labels
bug Something isn't working

Comments

@nemrutco
Copy link

When i use it with BelongsTo relationship, labels are becomes like :

profile[0][id_number] - profile[0][name] ... etc.

@nemrutco
Copy link
Author

Seems like it's related to Nova's 2.9.3 update, Nova will now use the give field name first for determining a field's label.. #764

@brandonferens
Copy link
Member

@nemrutco Thanks for this info. We'll look into it, but in the meantime feel free to submit a PR for this issue. We enjoy working with the community!

@brandonferens brandonferens added the bug Something isn't working label Jan 16, 2020
@4n70w4
Copy link

4n70w4 commented Jan 28, 2020

The same problem on create form:

image

@kculmback
Copy link

kculmback commented Feb 16, 2020

Also experiencing the same issue with Nova 2.10.1

@Dixens
Copy link

Dixens commented Mar 2, 2020

Also experiencing the same issue with Nova 2.11.1

And really nice package by the way - really should make it into the core.

@david-kristin
Copy link

I have the same problem with HasMany relation.

@drewwbctz
Copy link

Same issue with Nova 2.12.0

@Dixens
Copy link

Dixens commented Mar 9, 2020

OK now, even with Nova 2.11.1. Thanks.

@genesiscz
Copy link
Contributor

I just wasted an hour trying to make this work (I had to figure out how to refresh the compiled files), but it seems there's a fix already

1d9d487

@genesiscz
Copy link
Contributor

genesiscz commented Mar 19, 2020

here's how I applied this in my project (maybe unsafe):

composer.json:

        "kirschbaum-development/nova-inline-relationship": "dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb",


or maybe

composer require "kirschbaum-development/nova-inline-relationship=dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb"
composer install
cd vendor/kirschbaum-development/nova-inline-relationship
npm i
npm run watch
rm -rf node_modules/

done

@skoyah
Copy link

skoyah commented Mar 31, 2020

Maybe is missing a tag release?

@Dixens
Copy link

Dixens commented Apr 29, 2020

OK now, even with Nova 2.11.1. Thanks.

Back to labels as arrays for some reason (no update).

@gshzn
Copy link

gshzn commented May 5, 2020

Any idea when this will be pushed to packagist?

@cch504
Copy link

cch504 commented May 5, 2020

I can confirm this issue.

@mauricewaney
Copy link

Any updates or workarounds for this issue?

@genesiscz
Copy link
Contributor

here's how I applied this in my project (maybe unsafe):

composer.json:

        "kirschbaum-development/nova-inline-relationship": "dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb",

npm install
cd vendor/kirschbaum-development/nova-inline-relationship
npm i
npm run watch
rm -rf node_modules/

done

Try this

@vwasteels
Copy link

Hello,
I just tried the solution abose, but still see the labels as articles[0][title]
Thank you

@vwasteels
Copy link

oh it's composer update instead of npm install :

in composer.json:
"kirschbaum-development/nova-inline-relationship": "dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb",

composer install
cd vendor/kirschbaum-development/nova-inline-relationship
npm i
npm run prod
rm -rf node_modules/

@genesiscz
Copy link
Contributor

ah yeah sorry for that

@vwasteels
Copy link

@kirschbaum do you plan to integrate this fix into a future release ?

@ragingdave
Copy link

@kirschbaum Just poking this issue once more to try and get a new release if this is in fact already fixed?

@Milkhan
Copy link

Milkhan commented Jul 26, 2020

@kirschbaum Is this repo abandoned? Any help?

@NioTeX
Copy link

NioTeX commented Aug 31, 2020

@brandonferens any chance to get a new release?

@genesiscz
Copy link
Contributor

genesiscz commented Sep 1, 2020

I forked a forked repo of this repo and compiled the files to make it work out of the box - feel free to add

"repositories": [

        {
            "type": "vcs",
            "url": "https://github.com/genesiscz/nova-inline-relationship"
        }
]

to your composer json and then composer require kirschbaum-development/nova-inline-relationship

@jberculo
Copy link

jberculo commented Sep 9, 2020

@genesiscz I tried to use your fork, but my HasOne inline now complains about "Too few arguments to function Laravel\Nova\Fields\HasOne::KirschbaumDevelopment\NovaInlineRelationship\{closure}(), 0 passed and exactly 1 expected",

@ragingdave
Copy link

@kirschbaum @brandonferens any updates here or is this repo abandoned? There has been no updates/comments from you guys for quite some time, and nothing has happened in this repo for coming up on 6 months. This package is currently broken for Nova v2/3 so basically anyone wanting to use it are currently SOL without maintaining their own fork.

@kirschbaum
Copy link
Member

kirschbaum commented Sep 9, 2020

@ragingdave we'd love to work on this more. There are two issues: 1) we're extremely busy at the moment and haven't had time to focus on this yet and b) there are some major issues with how this package needed to be created. It's been making fixing bugs and keeping the package updated very challenging.

If anyone is interested in helping to take these issues on let me know and we can have a quick call with you to discuss. These issues are quite complex and require deep understanding of Laravel and Nova. Would love to see this project move forward and succeed.

@ragingdave
Copy link

@kirschbaum I would be interested in helping, as the end result of this package is something that would be very useful to me and my team and I'm sure, based on previous comments, others as well.

@genesiscz
Copy link
Contributor

@genesiscz I tried to use your fork, but my HasOne inline now complains about "Too few arguments to function Laravel\Nova\Fields\HasOne::KirschbaumDevelopment\NovaInlineRelationship{closure}(), 0 passed and exactly 1 expected",

Pass a $request to the inline()

@kirschbaum
Copy link
Member

@ragingdave I have sent you an email invite for us all to sync. Let me know if you didn't get it.

@trippo
Copy link

trippo commented Nov 4, 2020

@genesiscz Why does sortUsing no longer exist?

@Reached
Copy link

Reached commented Dec 2, 2020

Hi guys,

Thanks for providing this package, it's great! However, any updates on fixing this label issue? :)

@genesiscz
Copy link
Contributor

@genesiscz Why does sortUsing no longer exist?

I honestly have no idea. I merged another fork with my own edits and made it work for my use case. You can always debug it and post a pull request to the fork I created.

@halberio
Copy link

halberio commented Jan 3, 2021

@genesiscz
I passed the $request to the HasMany but it gives me Method Illuminate\Database\Eloquent\Collection::getKeyName does not exist. do you have any idea?

@genesiscz
Copy link
Contributor

Without more info, no, unfortunatelly

@cbrinicombe13
Copy link

Any update on a fix for this issue?

@GerhardKotze
Copy link

same problem :(

@o1y
Copy link

o1y commented Apr 24, 2021

I forked this repo to build the outdated dist files, which does not contain PR #59.

Add my fork to your composer.json:

"repositories": [
  {
    "type": "vcs",
    "url": "https://github.com/o1y/nova-inline-relationship"
  }
],

and require the package:

composer require kirschbaum-development/nova-inline-relationship

@Santukon
Copy link

@o1y Works perfect. If you could include also fix for this bug would be awesome: #87
Regards!

@alekmlynek
Copy link

@o1y Thank you, worked great. Hopefully core will get fixed.

@Igor-Nosatov
Copy link

Guys, it is easy, just fix vue.js components

@RhysLees
Copy link

Still got the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests