New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make declaration of Delayed and Sockets are the same #18

Open

peterngockhoa wants to merge 1 commit into kissmetrics:master from peterngockhoa:master

peterngockhoa commented Jun 11, 2016 •

edited

Loading

I cannot use Delayed class because PHP said that:

PHP Strict Standards:  Declaration of KISSmetrics\Transport\Delayed::initDefault() should be
compatible with KISSmetrics\Transport\Sockets::initDefault()

Should I implement like this? Or just need to add public static function initDefault($log_dir = null) to Sockets and Delayed as #19?


          Make declaration of Delayed and Sockets are the same

f71e0f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet