Fix weird behavior on moving through pages #291 #322
Conversation
…ent element's offset without weird behavior.
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| internal let MenuViewItemsMarginRigth: CGFloat = 20 | |||
There was a problem hiding this comment.
Can you explain why we have static right margin?
There was a problem hiding this comment.
Hi Kitasuke. First of all thanks for your framework.
So I declared it that way so it could be easy to change later if the right margin was not the desired. Because of some constants like MinimumSupportedViewCount, in that moment I thought it will make sense. Honestly looking at it right now probably will be better to just have a constant inside the same function contentOffsetXForCurrentPage.
Let me know what you think.
Thanks !
There was a problem hiding this comment.
I understand that it makes easier, but I actually prefer not to have static value. Anyway I'll wait for this answer to understand what the case is at first.
There was a problem hiding this comment.
Thanks for you answer. Then this static margin wouldn't be appropriate way, because this change is supposed to be for dynamic change of the number of items. In addition, I'm not sure this approach would be suitable for other cases as well.
Ideally there should be method which can change it's option, but it's still in progress...
Well, let me think different approach.
There was a problem hiding this comment.
Awesome, let me know if I can help you.
Fixes # .
Changes proposed in this pull request: