Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation (1.0.0a1) #1

Open
4 of 6 tasks
tisto opened this issue Nov 29, 2023 · 1 comment
Open
4 of 6 tasks

Initial implementation (1.0.0a1) #1

tisto opened this issue Nov 29, 2023 · 1 comment

Comments

@tisto
Copy link
Member

tisto commented Nov 29, 2023

ToDo

  • create "Logos Block" (copy of Grid Block)
  • allow adding "Logo" subblocks
  • allow adding a title to a "Logo" subblock
  • when choosing an existing image the title of the image will be copied over to the "Logo" subblock
  • allow adding a link to a logo
  • take into account that we will add an option "grey out logos on hover" at a later point (in case we have to prepare anything)

Visual Design

We implement the "Logos only" version only for now:

Logo-Block_ Colored

Greyed out on hover version (later):

Logo-Block_ Black   White

@tisto tisto changed the title Initial implementation Initial implementation (1.0.0a1) Nov 29, 2023
@tisto
Copy link
Member Author

tisto commented Dec 17, 2023

@jackahl the criteria for the initial implementation are not met yet:

  • when choosing an existing image the title of the image will be copied over to the "Logo" subblock -> this doesn't work
  • we show a description field, which wasn't specified. if we keep it it should be a multi-line field
  • the image label has a description "It is advised to use a svg graphic." -> this is not correct AFAIK, we only support SVG graphics, isn't that correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant