Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically created images don't appear in meta.xml #6065

Open
mnscholz opened this issue May 7, 2024 · 3 comments
Open

Automatically created images don't appear in meta.xml #6065

mnscholz opened this issue May 7, 2024 · 3 comments
Labels

Comments

@mnscholz
Copy link
Contributor

mnscholz commented May 7, 2024

Describe the bug

I have a workflow script step that calls a shell script that generates derivative images of the main tiffs.
The directory where the images get stored is declared in the project settings as shown below:

Although it says that the images should get included in the METS, they will not appear as a mets:fileGrp in the
meta.xml during the whole workflow, only in the exported METS they are included correctly.

In the workflow script step, the properties for reading/writing/validating images are set.

Expected behavior
The created images should appear in the meta.xml directly after the step has finished.

Edit: / Note:
The meta.xml (or more precisely its mets:fileSec) does only seem to get updated when clicking the Save button in the metadata editor, independently of the current process status. On the other side, the step's properties don't seem to have any effect on updating/re-reading the image directories.
This seems to be counter-intuitive as to the properties' namings.

This issue mentions this behavior of the Save button. Can this behavior be triggered somehow in an automatic step?

Screenshots
grafik

Release
3.5.0

@mnscholz mnscholz added the bug label May 7, 2024
@BartChris
Copy link
Collaborator

BartChris commented May 7, 2024

#4450

Original issue: #3333
To elaborate: It should be possible to define a automatic script task after your image generation step. In this task you call the following kitodo action: action:searchForMedia, to add the refrences to the METS file. I have not tested it myself but it should work. Would that functionality help you?

@mnscholz
Copy link
Contributor Author

Yes that helps, thanks a lot!
Is it also possible to trigger the action from outside Kitodo, ie. from the shell script that got called by Kitodo?

I leave this issue open as I still consider it a bug that the workflow step properties write/validate images won't update the meta.xml, which IMO is the expected behaviour.

@BartChris
Copy link
Collaborator

Yes that helps, thanks a lot! Is it also possible to trigger the action from outside Kitodo, ie. from the shell script that got called by Kitodo?

Not yet, as far as i know. There is an open Pull Request for that functionality: #6013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants