New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use keyword for wildcardsearch #4263

Merged

Kathrin-Huber merged 2 commits into kitodo:master from Kathrin-Huber:make_underscore_searchable

Apr 13, 2021

Contributor

Kathrin-Huber commented Mar 9, 2021

fixes #3938


          use keyword for wildcardsearch

0a733c9

Kathrin-Huber requested a review from solth

March 9, 2021 13:10

solth approved these changes

View reviewed changes

Kitodo/src/test/java/org/kitodo/production/services/data/ProcessServiceIT.java Outdated

                       assertEquals(processNotFound, 1, processService.findByAnything("SecondMetaShort").size());
                   }
+                  @Test
+                  public void shouldFindProcessWithUnderscore() throws DataException, DAOException {
+                      Project projectDTO = ServiceManager.getProjectService().getById(1);

Member

solth Apr 6, 2021

Why is this variable called projectDTO? It is an instance of Project, not ProjectDTO.


          add review

Kathrin-Huber merged commit d45bc91 into kitodo:master

Kathrin-Huber deleted the make_underscore_searchable branch

April 13, 2021 12:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet