fix infinite scroll

kitsune-soc · Oct 15, 2023 · eed4979 · eed4979
1 parent 4a4d2a5
commit eed4979
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/kitsune-fe/src/graphql/timeline.ts b/kitsune-fe/src/graphql/timeline.ts
@@ -37,7 +37,7 @@ function getHome(after: Ref<string>) {
       }
     `),
     variables: {
-      after: after as unknown as string,
+      after: after as unknown as string, // Weird cast to allow reactivity
     },
   });
 

diff --git a/kitsune-fe/src/views/timeline/FederatedPage.vue b/kitsune-fe/src/views/timeline/FederatedPage.vue
@@ -15,9 +15,7 @@
 
   const localTimelineQuery = getPublic(lastPostId, false);
   watch(localTimelineQuery, (newTimelineQuery) => {
-    (newTimelineQuery?.publicTimeline.nodes ?? []).forEach((post) =>
-      posts.value.push(post),
-    );
+    posts.value = newTimelineQuery?.publicTimeline.nodes ?? [];
   });
 
   async function loadMore(): Promise<void> {

diff --git a/kitsune-fe/src/views/timeline/HomePage.vue b/kitsune-fe/src/views/timeline/HomePage.vue
@@ -15,9 +15,7 @@
 
   const homeTimelineQuery = getHome(lastPostId);
   watch(homeTimelineQuery, (newTimelineQuery) => {
-    (newTimelineQuery?.homeTimeline.nodes ?? []).forEach((post) =>
-      posts.value.push(post),
-    );
+    posts.value = newTimelineQuery?.homeTimeline.nodes ?? [];
   });
 
   async function loadMore(): Promise<void> {

diff --git a/kitsune-fe/src/views/timeline/LocalPage.vue b/kitsune-fe/src/views/timeline/LocalPage.vue
@@ -15,9 +15,7 @@
 
   const localTimelineQuery = getPublic(lastPostId, true);
   watch(localTimelineQuery, (newTimelineQuery) => {
-    (newTimelineQuery?.publicTimeline.nodes ?? []).forEach((post) =>
-      posts.value.push(post),
-    );
+    posts.value = newTimelineQuery?.publicTimeline.nodes ?? [];
   });
 
   async function loadMore(): Promise<void> {
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,7 +37,7 @@ function getHome(after: Ref<string>) { @@
           }
         `),
         variables: {
-          after: after as unknown as string,
+          after: after as unknown as string, // Weird cast to allow reactivity
         },
       });
@@ Expand Down @@