Check Content-Type header when fetching entities
#388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aumetra
force-pushed
the
aumetra/verify-content-type
branch
from
953eed8 to
65e489d
Compare
|
(@tesaguri just waiting for a small +1 if this is what you imagined) |
tesaguri
suggested changes
Oct 26, 2023
|
Added a minor question comment (#388 (comment)). Otherwise looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks to verify that the server actually returned an valid ActivityPub content type.
We do this to prevent situations where someone would, for example, host actors on things like GitHub Gists where a malicious actor could appear to be hosted on
gist.github.com, giving them some credibility.