This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
Handle missing values when building a routing key #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following panic when not enough bound values are present:
```
panic: runtime error: index out of range [0] with length 0
goroutine 663 [running]:
github.com/gocql/gocql.createRoutingKey(0xc0004b4000, {0x0, 0x0, 0xc000042360?})
/go/pkg/mod/github.com/kiwicom/[email protected]/session.go:2097 +0x58d
github.com/gocql/gocql.(*Query).GetRoutingKey(0xc00089e8c0)
/go/pkg/mod/github.com/kiwicom/[email protected]/session.go:1231 +0x446
github.com/gocql/gocql.(*tokenAwareHostPolicy).Pick(0xc0000f2380, {0x195da60, 0xc00089e8c0})
/go/pkg/mod/github.com/kiwicom/[email protected]/policies.go:574 +0x64
github.com/gocql/gocql.(*queryExecutor).executeQuery(0xc000a12060, {0x195da60, 0xc00089e8c0})
/go/pkg/mod/github.com/kiwicom/[email protected]/query_executor.go:67 +0x96
github.com/gocql/gocql.(*Session).executeQuery(0xc00051fb00, 0x3?)
/go/pkg/mod/github.com/kiwicom/[email protected]/session.go:548 +0x145
github.com/gocql/gocql.(*Query).Iter(0xc00089e8c0)
/go/pkg/mod/github.com/kiwicom/[email protected]/session.go:1372 +0x13f
github.com/scylladb/gocqlx/v2.(*Queryx).Iter(...)
/go/pkg/mod/github.com/scylladb/gocqlx/[email protected]/queryx.go:344
```
medasx
approved these changes
Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following panic when not enough bound values are present: