Change bouncer cap to a vendor cap #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n IRCv3 ratified capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we use the capability name
bouncer, which isn't great because it's not yet a ratified IRCv3 cap. This makes the capability namekiwiirc.com/bouncerand also adds theunknown_subcommandresponse to theBOUNCERcommand to let clients detect when a feature is not supported (very useful for extending the command going into the future).Here's my very slightly updated BOUNCER doc, the changes should probably be pulled on top of the original spec doc:
The change which fixes the
BOUNCERcap name in particular may conflict slightly with the echo-message PR, but in the end this PR's changes should prevail there.