Skip to content

Commit 756afb1

Browse files
committed
Add dev goals section, add more core devs and minor updates
1 parent 4d69ce5 commit 756afb1

File tree

1 file changed

+24
-9
lines changed

1 file changed

+24
-9
lines changed

source/developer/core-developer-handbook.md

+24-9
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,25 @@ Below is the list of core developers working on Mattermost:
1313
- Harrison Healey - @harrison on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@hmhealey](https://github.com/hmhealey) on GitHub
1414
- Elias Nahum - @elias on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@enahum](https://github.com/enahum) on GitHub
1515
- George Goldberg - @george on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@grundleborg](https://github.com/grundleborg) on GitHub
16+
- Saturnino Abril - @saturnino on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@saturninoabril](https://github.com/saturninoabril) on GitHub
17+
- Chris Duarte - @uberchris on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@csduarte](https://github.com/csduarte) on GitHub
1618

1719
Below is the list of core developers working on individual Mattermost repositories:
1820
- Pan Luo - [mattermost-docker](https://github.com/mattermost/mattermost-docker) - @compass on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@xcompass](https://github.com/xcompass) on GitHub
1921
- Yuya Ochiai - [desktop](https://github.com/mattermost/desktop) - @yuya-oc on [pre-release.mattermost.com](https://pre-release.mattermost.com/) and [@yuya-oc](https://github.com/yuya-oc) on GitHub
2022

21-
### Reviewing & Merging Pull Requests ###
23+
### Technical Development Goals ###
2224

23-
Core developers are expected to code review pull requests submitted to the Mattermost repositories. Below are some guidelines for reviewing code:
25+
We discuss these goals every other week during the [weekly developer meeting](https://docs.mattermost.com/process/training.html#developer-meeting).
2426

25-
- Responsibility for the submitted code relies on the submitter, it is their responsibility to test and implement any changes at high quality. As a result, code reviewers are not required to do a full audit of code changes but should read through the code to:
26-
- Make sure the implementation matches the description of the ticket being completed
27-
- Ask questions about anything that is not clear
28-
- To request changes when the code looks incorrect or doesn't match the correct design patterns
29-
- Stable respositories that have had a 1.0.0 release require two approved reviews before the changes can be merged
30-
- Unstable repositories that are still in development may be merged with a single approved review
31-
- Trivial changes, such as PM-approved text changes or typo fixes, maybe merged with only a single approved review for both stable and unstable repositories
27+
#### Short Term ####
28+
- Performance for 20,000 daily active users
29+
- React Native mobile apps
30+
31+
#### Long Term ####
32+
- Performance for 200,000 daily active users, 200 million messages per month
33+
- Orchestration/SAAS
34+
- Developer Toolkit (APIs, plugins, integrations, samples, documentation)
3235

3336
### Technical Direction Resolutions ###
3437

@@ -41,6 +44,18 @@ Technical direction resolutions are any decisions made by the team affecting the
4144
5. Removing localization of the server logs. We haven't found it beneficial to localize these messages, and in some cases it has made it more difficult for us to help troubleshoot issues for non-English users. This will also reduce some of the work required when translating Mattermost. ([https://pre-release.mattermost.com/core/pl/13xdrfnw5bb5mnagth5kt48kyr](https://pre-release.mattermost.com/core/pl/13xdrfnw5bb5mnagth5kt48kyr))
4245
6. All new webapp components should be built against Redux and [follow the new guide](https://docs.mattermost.com/developer/webapp-component.html)
4346

47+
### Reviewing & Merging Pull Requests ###
48+
49+
Core developers are expected to code review pull requests submitted to the Mattermost repositories. Below are some guidelines for reviewing code:
50+
51+
- Responsibility for the submitted code relies on the submitter, it is their responsibility to test and implement any changes at high quality. As a result, code reviewers are not required to do a full audit of code changes but should read through the code to:
52+
- Make sure the implementation matches the description of the ticket being completed
53+
- Ask questions about anything that is not clear
54+
- To request changes when the code looks incorrect or doesn't match the correct design patterns
55+
- Stable respositories that have had a 1.0.0 release require two approved reviews before the changes can be merged
56+
- Unstable repositories that are still in development may be merged with a single approved review
57+
- Trivial changes, such as PM-approved text changes or typo fixes, maybe merged with only a single approved review for both stable and unstable repositories
58+
4459
### Useful Guides and Documentation ###
4560
- [Adding a webapp component](https://docs.mattermost.com/developer/webapp-component.html)
4661
- [Adding actions and selectors to Redux](https://docs.mattermost.com/developer/redux.html)

0 commit comments

Comments
 (0)