Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement eth_get_transaction_count #942

Closed
enitrat opened this issue Sep 13, 2024 · 5 comments · Fixed by #983
Closed

feat: implement eth_get_transaction_count #942

enitrat opened this issue Sep 13, 2024 · 5 comments · Fixed by #983
Assignees
Labels
enhancement New feature or request ODHack8

Comments

@enitrat
Copy link
Contributor

enitrat commented Sep 13, 2024

fn eth_get_transaction_count(self: @TContractState, address: EthAddress) -> u64 {
panic!("unimplemented")
}

Given an evm address, this will return the transaction count (none) of this address.

Use it where required in the codebase, for example:

// Validate nonce
let starknet_caller_address = get_caller_address();
let account = IAccountDispatcher { contract_address: starknet_caller_address };
assert(account.get_nonce() == tx.nonce(), 'Invalid nonce');

reference:

https://github.com/kkrt-labs/kakarot/blob/main/src/kakarot/eth_rpc.cairo#L43-L50

@enitrat enitrat added the enhancement New feature or request label Sep 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 13, 2024
@Gerson2102
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged


Hey! I'm Gerson. 👋

Member of Dojo Coding. I have contributed before to other Kakarot projects like:

  • kakarot-rpc
  • ef-tests

Can I work on this issue?

Check my OnlyDust profile, I've contributed to many projects: Profile

How I plan on tackling this issue


Plan to Solve the Issue:

  1. Study the codebase to understand the current structure and functionality.
  2. Understand the problem that needs to be solved by thoroughly reading the issue details.
  3. Leverage all provided resources within the issue to get a better grasp of the task at hand.
  4. If I encounter roadblocks, I will ask questions ASAP in the Telegram group to move forward effectively.
  5. I will open a PR and wait for ur feedback

@manlikeHB
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I am Cairo Developer with lots of experience contributing to Cairo projects, you can check my profile to be sure of this.

How I plan on tackling this issue

I would go through the code base and understand what is needed and ensure I do just that, after that I would write a robust test ensuring all test cases are covered and the feat behaves as expected.

@mubarak23
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

My recent work with cairo starknet

My recent work with rust

How I plan on tackling this issue

Am going to

  • implement the function
  • Look through the codebase where ever the function is call and make sure the code build successfully
  • Write unit test for the function
    ETH: 18hrs

1 similar comment
@mubarak23
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

My recent work with cairo starknet

My recent work with rust

How I plan on tackling this issue

Am going to

  • implement the function
  • Look through the codebase where ever the function is call and make sure the code build successfully
  • Write unit test for the function
    ETH: 18hrs

Copy link

onlydustapp bot commented Sep 26, 2024

The maintainer enitrat has assigned Gerson2102 to this issue via OnlyDust Platform.
Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ODHack8
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants