refactor: use a match table for execute_opcode" #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add validate_eth_tx test * polish: fmt + docstrings
* First batch of replacements * Second batch of replacements * Clean commented code * scarb fmt * Apply code review recommendations
* ceil to bytes32 * overflow and nits
* load word to bytes * unwrap and nits
* implement eth_get_balance * add missing files * made requested changes * fmt --------- Co-authored-by: enitrat <[email protected]>
* dev: use native in ci * remove outdated gas reports * fix fmt * fix runtime location * avoid clearing the ssj checkout * use correct working dir * update stack size when running rust ef-tests * update workflows * simplify workflows by avoiding re-building runtimes * rework workflow structure
* dev: implement compile-time filtering * fmt
* Implementation of eth_get_transaction_count function * Refactoring validate nonce in validation.cairo * Changing the deprecated function * Validating nonce without new function * Adding method to interface and test it * fix tests * fmt --------- Co-authored-by: enitrat <[email protected]>
* fix: mulmod * fmt
* fix: overflow in message_call_gas * fmt
* fix typos * fix typo * fix typos * fix typo * fix typo
* fix: saturate jumpi index taken on stack * scout: remove print
dev: optimized bitshifts by using a lookup table for powers of two tmp
* fix: conversion of stack values in opcode execution * fix test
* test_kakarot_core_get_starknet_address * ci: downgrade cairo native (#1008) * dev: use checked math (#1009) * fix get_starknet_address test --------- Co-authored-by: Mathieu <[email protected]>
* creating test case for emit events * fixing format * side stuff * Update crates/evm/src/model.cairo Co-authored-by: Mathieu <[email protected]> * Update crates/evm/src/backend/starknet_backend.cairo Co-authored-by: Mathieu <[email protected]> * changes for implementation of into trait --------- Co-authored-by: enitrat <[email protected]> Co-authored-by: Mathieu <[email protected]>
* dev: optimize to u64 words * opti from_le_bytes * dev: optimize ToBytes * fmt * fix bug
…1012) * refactor: decode_legacy_tx for consistency with typed transactions * fmt --------- Co-authored-by: enitrat <[email protected]>
* refactor: eth_send_raw_transaction * fix tests * fix test * revert unwanted change
obatirou
reviewed
Oct 7, 2024
| // STOP | ||
| return Result::Ok(self.exec_stop()); | ||
| match opcode { | ||
| 0 => // STOP |
There was a problem hiding this comment.
Would be better in hex notation no ?
obatirou
reviewed
Oct 7, 2024
| 12 => Result::Err(EVMError::InvalidOpcode(opcode)), | ||
| 13 => Result::Err(EVMError::InvalidOpcode(opcode)), | ||
| 14 => Result::Err(EVMError::InvalidOpcode(opcode)), | ||
| 15 => Result::Err(EVMError::InvalidOpcode(opcode)), |
There was a problem hiding this comment.
Why adding those ?
Removing it might be easier to read and will go into the default case
There was a problem hiding this comment.
I can't skip numbers unfortunately they have to be sequential 😮💨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more optimized than if / elses
This change is