Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon-label spacing #9

Open
gbit00 opened this issue Jan 28, 2024 · 13 comments
Open

Icon-label spacing #9

gbit00 opened this issue Jan 28, 2024 · 13 comments
Labels
enhancement New feature or request

Comments

@gbit00
Copy link

gbit00 commented Jan 28, 2024

Firstly thank you for your amazing applet!I love your app and the added functionality. With a guy like me, however, with way too many things open at any given time, the extra space between icon and label is a huge waste of space. I was wondering if there is a setting trick to get the labels closer to the icons? I have tried several different font, sizes, messing with settings everywhere, and I can't seem to close the gap. Thanks for your time.

Here is a picture of both Cassia and another window list to contrast the difference in label location.
Screenshot from 2024-01-27 20-21-47
Screenshot from 2024-01-27 20-24-49

@klangman
Copy link
Owner

Glad you like the applet.

First off, it looks like you are using different themes between the two screen shots?? The theme has a lot of control over padding and margins so if I am right and you have different themes in use then picking a theme with less padding might help. On the other hand, if you are using the same theme, then I am a little confused by the major differences in how the two window-lists look. Can you tell me the theme you are using and the name of the other window-list in the 2nd screen shot? Maybe I can try to recreate the issue.

Next, for window-list buttons without labels Cassia will reserve some label space for the indicator characters that you have enabled. If you go the the Cassia settings, then the "Labels" tab and set "Display status indicators" to "None", Cassia will stop reserving label space for status indicator characters. I don't think this will address all of your issues but this might help a bit.

Lastly, there is a new option in my GitHub version that allows you to add space to the start and end of buttons, but it defaults to 0 and if you have not installed the GitHub version then it can't be the cause of you problem since the cinnamon-spices version does not have this option yet and therefore can't be adding any extra spacing.

So yeah, let me know what theme you are using and what that 2nd window-list applet is and I will see about recreating your issue.

@klangman
Copy link
Owner

One correction... The icon spacing option was already pushed to cinnamon-spices, so the icon spacing might be part of the problem even on the cinnamon-spices version.

@klangman
Copy link
Owner

It's been a long time.. I'll assume you found a way to fix your issue. Closing the issue.

@gbit00
Copy link
Author

gbit00 commented Oct 20, 2024

Re: Icon-label spacing:
Nope the theme never changed. Will include a screenshot with both window lists on either end of the same panel. I double checked and I have 'display status indicators' set to none, and the other window list pictured was the default window list ([email protected].). I have noticed the space I have a gripe with, directly to the right of the icon, persits whether there is a label or not, and does not shrink when you shrink the width of the button/label. I very much doubt that is the behavior you desired so it seems that is definitely a bug.
cassia screenshot

@klangman klangman reopened this Oct 21, 2024
@klangman
Copy link
Owner

How does CobiWindowList compare? Wondering if this is something I did or does the code base I started with have the same issue?

@gbit00
Copy link
Author

gbit00 commented Oct 21, 2024

I just installed cobi and indeed it seems to have the same spacing issue!

@klangman
Copy link
Owner

I can see the issue now when I switch to the "CBlue" theme. The difference is with the containers that I am using to hold the buttons. I'll see what I can do about it. Cobi (and by extension Cassia) uses a BoxLayout container and the default window lists are using a Cinnamon.GenericContainer.

@gbit00
Copy link
Author

gbit00 commented Oct 21, 2024

The "issue" is even more pronounced with large icons and narrower buttons. On a side note, not a request per se, just a question, is there a way to disable all popups (thumbnail or text) when hovering? In certain situations, which I am failing to reproduce now, the text was unreadable and the pop up unnecessary. Cheers!
windowlist2

@klangman
Copy link
Owner

is there a way to disable all popups (thumbnail or text) when hovering?

In the config menu you can disable the "tooltip" text by turning off the "Show tooltips for window list buttons" option under the general tap. You can disable the thumbnail menus by disabling the "Show on hover" option under the "Thumbnails" tab.

@klangman klangman added the enhancement New feature or request label Oct 25, 2024
@klangman
Copy link
Owner

Switching to GenericContainer from BoxLayout will require more work then I expected. Fixing this might be a while longer. This change won't be in the next release, but I am still looking into it.

@gbit00
Copy link
Author

gbit00 commented Nov 10, 2024

Right on! I'm wondering if the difference in container has any thing to do with why some of the different window lists respond differently to cinnamon font settings (as in the picture above)?

@gbit00
Copy link
Author

gbit00 commented Nov 14, 2024

Can I ask which theme you were using that avoided you seeing the spacing issue? I have tried various default and alternative themes and the spacing persists, albeit I have done so without restarting... I assume it is a desktop theme not an application theme?
Edit: I can see now with the Mint-X, Mint-Y, and Mint-L themes the problem is much less. Interestingly, the issue is almost non-existent with this "windows dark" theme, albeit being a pretty basic/ugly theme, imo. You can directly download it here

@klangman
Copy link
Owner

I am using the Mint-Y desktop theme, and with that theme I see no major difference between CWL and the default window lists in terms of spacing (as you also have noticed as per your edit).

Forgot to respond to your question about the font differences. I was not sure what part of the picture your were referring to with regards to the font?? Maybe you can help clarify?

Sorry for the delay on this spacing issue.. I have been busy with a bunch of improvements to the Desktop-Cube extension. I hope to get that done sometime next week and then I should have some time to resume working on some CWL issues including changing the container CWL is using. I haven't forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants