-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed Up our rituals, iesnium and eldritch upgrades and otherthings #1257
base: version/1.21.1
Are you sure you want to change the base?
Conversation
@Eqis-Edu as always, fanstastic content! |
i understand that otherglass is a bit special in that it is invisible compared to other (other-)items like otherstone and otherwood but do we really need to use iesnium (nuggets) and endstone (dust)? if throwing glass in spiritfire is a bit too.. much? how about acquiring it through a trader that you have to summon also like otherstone? if yall think the recipe cost is justified then ignore my comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh not used to modded mc so please be merciful w me
entityData = this.saveWithoutId(entityData); | ||
|
||
shard.set(DataComponents.ENTITY_DATA, CustomData.of(entityData)); | ||
this.setHealth(health); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasnt his health set in l98 already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes the life inside the soul shard when dropped, since the copy as 0 health
this.pageTitle("Iesnium Golem"); | ||
this.pageText(""" | ||
An Iesnium Golem is a direct upgrade from a regular Iron Golem, this new version is much stronger and invulnerable. \\ | ||
Only a player can dismiss them, by hitting while is crouched, returning the {0}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a player can dismiss them, by hitting while is crouched, returning the {0}. | |
Only a player can dismiss them, by hitting while crouched, returning the {0}. |
"occultism:infused_pickaxe", | ||
"occultism:iesnium_pickaxe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i highly suggest documenting this somewhere in the dict of spirits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added under description
The recipe use a new base and matrix, not the actuator (because it does not copy the items inside) |
"book_of_binding_empty", () -> new BookOfBindingItem(defaultProperties().stacksTo(16))); | ||
public static final DeferredItem<BookOfBindingItem> BOOK_OF_BINDING_FOLIOT = ITEMS.register( | ||
"book_of_binding_foliot", () -> new BookOfBindingItem(defaultProperties().stacksTo(1))); | ||
"book_of_binding_foliot", () -> new BookOfBindingItem(defaultProperties().stacksTo(16))); | ||
public static final DeferredItem<BookOfBindingBoundItem> BOOK_OF_BINDING_BOUND_FOLIOT = ITEMS.register( | ||
"book_of_binding_bound_foliot", () -> new BookOfBindingBoundItem(defaultProperties().stacksTo(1).component(OccultismDataComponents.SPIRIT_NAME, TextUtil.SPIRIT_NAME_NOT_YET_KNOWN))); | ||
public static final DeferredItem<BookOfBindingItem> BOOK_OF_BINDING_DJINNI = ITEMS.register( | ||
"book_of_binding_djinni", () -> new BookOfBindingItem(defaultProperties().stacksTo(1))); | ||
"book_of_binding_djinni", () -> new BookOfBindingItem(defaultProperties().stacksTo(16))); | ||
public static final DeferredItem<BookOfBindingBoundItem> BOOK_OF_BINDING_BOUND_DJINNI = ITEMS.register( | ||
"book_of_binding_bound_djinni", () -> new BookOfBindingBoundItem(defaultProperties().stacksTo(1).component(OccultismDataComponents.SPIRIT_NAME, TextUtil.SPIRIT_NAME_NOT_YET_KNOWN))); | ||
public static final DeferredItem<BookOfBindingItem> BOOK_OF_BINDING_AFRIT = ITEMS.register( | ||
"book_of_binding_afrit", () -> new BookOfBindingItem(defaultProperties().stacksTo(1))); | ||
"book_of_binding_afrit", () -> new BookOfBindingItem(defaultProperties().stacksTo(16))); | ||
public static final DeferredItem<BookOfBindingBoundItem> BOOK_OF_BINDING_BOUND_AFRIT = ITEMS.register( | ||
"book_of_binding_bound_afrit", () -> new BookOfBindingBoundItem(defaultProperties().stacksTo(1).component(OccultismDataComponents.SPIRIT_NAME, TextUtil.SPIRIT_NAME_NOT_YET_KNOWN))); | ||
public static final DeferredItem<BookOfBindingItem> BOOK_OF_BINDING_MARID = ITEMS.register( | ||
"book_of_binding_marid", () -> new BookOfBindingItem(defaultProperties().stacksTo(1))); | ||
"book_of_binding_marid", () -> new BookOfBindingItem(defaultProperties().stacksTo(16))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love these, awesome QOL changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take my approval w a grain of salt
src/main/java/com/klikli_dev/occultism/datagen/book/binding_rituals/TrinityGemEntry.java
Outdated
Show resolved
Hide resolved
…tuals/TrinityGemEntry.java Co-authored-by: orochi02 <[email protected]>
this morning after i woke up i had a thought: the stabilized storage actuator is really really nice but.. cant it be used like a shulker box? is having players taking a whole giant storage solution as a replacement backpack/shulker box really desirable? |
Players can already do this with the normal actuator (taking a few blocks and the stabilizers can quickly setup to enable placing items), but it's much simpler to just use the accessor (with the actuator in a loaded chunk, at world spawn or with another mod). |
@klikli-dev this PR is ready |
Sacrificial Bowls
Copper/Silver Sacrificial Bowl
Iesnium Sacrificial Bowl
Eldritch Chalice
(not really a bowl...)
Pentacles
Accepts the Iesnium sacrificial bowl and the Eldritch Chalice in the middle, but the preview only shows the golden sacrificial bowl to avoid spoilers
Ritual Duration
Due to the new methods to speed up rituals, the entire ritual duration has been revised, now follows a formula based on type and tier (and reordered in the datagen file)
Pedestals
Otherstone pedestal
Silver pedestal
Storage actuator base
Stabilized storage actuator
Stabilizer level 0
Iesnium Anvil
Otherglass
Otherflower
Iesnium Golem
Rainbow and Void Chalks
Pentacles
Accepts rainbow or void glyphs in any valid position, but the preview only shows default colored version to avoid confusion
Trinity gem
Others
Image
(yeah, some blocks already exist, but I put to see all variations)
https://github.com/user-attachments/assets/7de61a7d-9bbc-44e4-a0d4-16fcd19f0411
Flickering glyphs (rainbow and void), the pentacle still working