-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resetOn does not work for mutations #308
Comments
I implemented I will add this to the ROADMAP. Also I will take this into account implementing dedicated Sadly I cannot work on it immediately as I am very busy on next release which will be very huge #306 For now you could cheat a little. Mutation error is cleared on mutation request, see https://github.com/klis87/redux-saga-requests/blob/master/packages/redux-saga-requests/src/reducers/mutations-reducer.js#L36 So to clear error you can dispatch |
@ManuelHaag After thinking for a bit longer, I could accept PR with this, even though it will create merge conflicts for me on |
@ManuelHaag see |
We have multiple screens which use the same (mutation) action (let's call it
UPDATE
) and want to clear any error on unmounting of the screen by dispatching aRESET
action.Although the
meta
ofUPDATE
containsresetOn: [RESET]
, the mutation state does not get cleared properly.Checking the code of
src/reducers/network-reducer.js:34
, only thequeries
object is being checked for reset actions viasrc/reducers/requests-reducer.js:128
.The text was updated successfully, but these errors were encountered: