Merge pull request Expensify#37432 from kubabutkiewicz/ts-migration/c…

…onfig [TS migration] Migrate 'config.js' test to TypeScript
kmbcook · Mar 5, 2024 · 478050e · 478050e
2 parents 9c2f146 + 7c0606f
commit 478050e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/libs/E2E/types.ts b/src/libs/E2E/types.ts
@@ -1,3 +1,6 @@
+import type {TEST_NAMES} from 'tests/e2e/config';
+import type {ValueOf} from 'type-fest';
+
 type SigninParams = {
     email?: string;
 };
@@ -19,7 +22,7 @@ type NetworkCacheMap = Record<
 >;
 
 type TestConfig = {
-    name: string;
+    name: ValueOf<typeof TEST_NAMES>;
     [key: string]: string | {autoFocus: boolean};
 };
 

diff --git a/tests/e2e/config.js → tests/e2e/config.ts b/tests/e2e/config.js → tests/e2e/config.ts
@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- if the first value is '' nullish coalescing will return '' so leaving || for safty
 const OUTPUT_DIR = process.env.WORKING_DIRECTORY || './tests/e2e/results';
 
 // add your test name here …
@@ -88,3 +89,5 @@ export default {
         },
     },
 };
+
+export {TEST_NAMES};