Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artistpic and albumart don't show image properly anymore #32

Open
david-simons opened this issue Apr 30, 2022 · 4 comments
Open

artistpic and albumart don't show image properly anymore #32

david-simons opened this issue Apr 30, 2022 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@david-simons
Copy link

Getting a downloadable .jpeg instead of an embedded image back, on the albumart and artistpic commands (at least)
image

Discord desktop client for Windows:
Stable 126213 (75b3f22) Host 1.0.9004 Windows 10 64-Bit (10.0.19044)

Bot does have permissions: Send Messages, Embed Links, Attach Files, Use Application Commands

@kmrn kmrn added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 27, 2022
@kmrn
Copy link
Owner

kmrn commented Jun 2, 2022

After a quick glance it seems like the discord API changed something so that messages need to actually specify that they want to embed an image I think. https://discordjs.guide/popular-topics/embeds.html#using-the-embed-constructor

@dantco mentioned wanting to take a look at this so I may leave it to them

@david-simons
Copy link
Author

Thanks - curious if no one else complained?

@dantco
Copy link
Contributor

dantco commented Jun 2, 2022

You're the first, as far as we know! I went ahead and did some local tests, produced the same behavior you're seeing. I think this could be an issue with the Discogs API implementation. When opening the file attachments the bot returns, I'm getting an empty jpeg. Could be the wrong data is being returned, and it's trying to parse as an image. Might be why they're not embedding properly-- nothing to embed! I'll need to dive in to some docs over the weekend, evaluate how all of the APIs are interacting. Cheers!

@david-simons
Copy link
Author

also - are you embedding the image URL to the discogs site, or embedding a (resized) copy of the JPG/PNG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants