Bump golang to 1.23 #236
Open
Bump golang to 1.23 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
|
/hold for folks to chime in. |
knative-prow
bot
added
the
do-not-merge/hold
|
I wouldn't bump this late in the release cycle. |
Make sense, we started the release with initial batch of repos cut. This can wait & hold until the Knative 1.16. |
knative-prow
bot
removed
the
do-not-merge/hold
evankanderson
approved these changes
Nov 10, 2024
knative-prow
bot
added
lgtm
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dsimansk, evankanderson The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@upodroid @dprotaso @knative/knative-release-leads I wonder if we should jump on Go 1.23 before the next release cycle. What's your preference?
I'll follow-up with knative/infra PR for prow images if we agree to proceed.