Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: add support for experimental new filters API in trigger #1833

Open
Cali0707 opened this issue Jul 26, 2023 · 6 comments
Open

CLI: add support for experimental new filters API in trigger #1833

Cali0707 opened this issue Jul 26, 2023 · 6 comments
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Feature request

As part of preparing the experimental new filters API to Beta (tracked here: knative/eventing#5204), we should add support to kn to create these filters when creating a trigger.

Use case

With the new filters API entering Beta, more users will want to try it out. It would be convenient for them if they can use kn to create them, instead of being required to use yaml files to try out the new filters.

UI Example

kn trigger create mytrigger --new-filter filtertype=filtervalue
@Cali0707 Cali0707 added the kind/feature New feature or request label Jul 26, 2023
@Cali0707 Cali0707 moved this to 📋 Backlog in New Event Filtering Jul 26, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 26, 2023

@pierDipi @dsimansk @rhuss any thoughts on this?

@dsimansk
Copy link
Contributor

@Cali0707 +1.

There's only support to display new filters, but not build/define. #1794

Of course the tricky part is designing smooth UI elements for so many combinations possible.

@pierDipi
Copy link
Member

pierDipi commented Jul 27, 2023

@Cali0707 +1.

There's only support to display new filters, but not build/define. #1794

Of course the tricky part is designing smooth UI elements for so many combinations possible.

+1, we can also consider not supporting everything in the CLI as a starting point and reconsider later

@rhuss
Copy link
Contributor

rhuss commented Sep 19, 2023

Could be a good candidate for the 48h Knative hackathon.

@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Sep 19, 2023
@JuneOh710
Copy link

/assign

@JuneOh710 JuneOh710 removed their assignment Jan 4, 2024
@pierDipi
Copy link
Member

@dsimansk do you have a design/UI idea for this feature? In terms of what can be supported for the new trigger filters API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants