Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Loop Detection #8230

Open
Cali0707 opened this issue Oct 5, 2024 · 4 comments
Open

Proposal: Loop Detection #8230

Cali0707 opened this issue Oct 5, 2024 · 4 comments

Comments

@Cali0707
Copy link
Member

Cali0707 commented Oct 5, 2024

Problem
It is easy to accidentally create loops/cycles in an eventing system which can lead to events going in a cycle for a long time and consuming lots of resources. However, there are also many valid use cases for creating a cycle so we should not always disallow them.

This proposal is to:

  1. Add a feature flag to automatically reject resources that would complete a cycle
  2. Add a label which can be added to resources to allow for the cycle to be made anyways
  3. Emit an event from every resource involved in a cycle (to notify users that they have a cycle there).

A proposal doc is here: https://docs.google.com/document/d/1V_DiONSL9iV4iyRtzLFvAQfrtDEyi0ebkM5cvrY5gzY/edit?usp=sharing

Persona:
Administrators, developers

Exit Criteria
TODO

Time Estimate (optional):
5-10 days

Additional context (optional)
AWS Lambda added something similar here: https://aws.amazon.com/blogs/compute/aws-lambda-introduces-recursive-loop-detection-apis/

@Cali0707
Copy link
Member Author

Cali0707 commented Oct 5, 2024

/triage needs-wg-discussion

@Cali0707 Cali0707 added the kind/proposal Issues or PRs related to proposals. label Oct 5, 2024
Copy link

github-actions bot commented Jan 4, 2025

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2025
@Cali0707
Copy link
Member Author

Cali0707 commented Feb 3, 2025

/reopen
/remove-lifecycle stale

Copy link

knative-prow bot commented Feb 3, 2025

@Cali0707: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot reopened this Feb 3, 2025
@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant