unify sub-path param name between s2i and pack

Signed-off-by: Matej Vasek <[email protected]>
knative · Oct 19, 2023 · 5751ac9 · 5751ac9
1 parent 38e41cf
commit 5751ac9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/pkg/pipelines/resources/tekton/task/func-s2i/0.1/func-s2i.yaml b/pkg/pipelines/resources/tekton/task/func-s2i/0.1/func-s2i.yaml
@@ -26,7 +26,7 @@ spec:
       description: Reference of the image S2I will produce.
     - name: REGISTRY
       description: The registry associated with the function image.
-    - name: PATH_CONTEXT
+    - name: SOURCE_SUBPATH
       description: The location of the path to run s2i from.
       default: .
     - name: TLSVERIFY
@@ -78,14 +78,14 @@ spec:
         cat /env-vars/env-file
         echo "------------------------------"
 
-        /usr/local/bin/s2i --loglevel=$(params.LOGLEVEL) build $(params.PATH_CONTEXT) $(params.BUILDER_IMAGE) \
+        /usr/local/bin/s2i --loglevel=$(params.LOGLEVEL) build $(params.SOURCE_SUBPATH) $(params.BUILDER_IMAGE) \
         --image-scripts-url $(params.S2I_IMAGE_SCRIPTS_URL) \
         --as-dockerfile /gen-source/Dockerfile.gen --environment-file /env-vars/env-file
 
         echo "Preparing func.yaml for later deployment"
         func_file="$(workspaces.source.path)/func.yaml"
-        if [ "$(params.PATH_CONTEXT)" != "" ]; then
-          func_file="$(workspaces.source.path)/$(params.PATH_CONTEXT)/func.yaml"
+        if [ "$(params.SOURCE_SUBPATH)" != "" ]; then
+          func_file="$(workspaces.source.path)/$(params.SOURCE_SUBPATH)/func.yaml"
         fi
         sed -i "s|^registry:.*$|registry: $(params.REGISTRY)|" "$func_file"
         echo "Function image registry: $(params.REGISTRY)"

diff --git a/pkg/pipelines/tekton/task_defs.go b/pkg/pipelines/tekton/task_defs.go
@@ -360,7 +360,7 @@ var S2ITask = v1beta1.Task{
 				Description: "The registry associated with the function image.",
 			},
 			v1beta1.ParamSpec{
-				Name:        "PATH_CONTEXT",
+				Name:        "SOURCE_SUBPATH",
 				Description: "The location of the path to run s2i from.",
 				Default: &v1beta1.ParamValue{
 					Type:      "string",
@@ -435,14 +435,14 @@ echo "------------------------------"
 cat /env-vars/env-file
 echo "------------------------------"
 
-/usr/local/bin/s2i --loglevel=$(params.LOGLEVEL) build $(params.PATH_CONTEXT) $(params.BUILDER_IMAGE) \
+/usr/local/bin/s2i --loglevel=$(params.LOGLEVEL) build $(params.SOURCE_SUBPATH) $(params.BUILDER_IMAGE) \
 --image-scripts-url $(params.S2I_IMAGE_SCRIPTS_URL) \
 --as-dockerfile /gen-source/Dockerfile.gen --environment-file /env-vars/env-file
 
 echo "Preparing func.yaml for later deployment"
 func_file="$(workspaces.source.path)/func.yaml"
-if [ "$(params.PATH_CONTEXT)" != "" ]; then
-  func_file="$(workspaces.source.path)/$(params.PATH_CONTEXT)/func.yaml"
+if [ "$(params.SOURCE_SUBPATH)" != "" ]; then
+  func_file="$(workspaces.source.path)/$(params.SOURCE_SUBPATH)/func.yaml"
 fi
 sed -i "s|^registry:.*$|registry: $(params.REGISTRY)|" "$func_file"
 echo "Function image registry: $(params.REGISTRY)"

diff --git a/pkg/pipelines/tekton/templates_s2i.go b/pkg/pipelines/tekton/templates_s2i.go
@@ -93,7 +93,7 @@ func GetS2IPipeline(f fn.Function) (*v1beta1.Pipeline, error) {
 					},
 				},
 				v1beta1.Param{
-					Name: "PATH_CONTEXT",
+					Name: "SOURCE_SUBPATH",
 					Value: v1beta1.ParamValue{
 						Type:      "string",
 						StringVal: "$(params.contextDir)",
@@ -440,7 +440,7 @@ spec:
           value: $(params.imageName)
         - name: REGISTRY
           value: $(params.registry)
-        - name: PATH_CONTEXT
+        - name: SOURCE_SUBPATH
           value: $(params.contextDir)
         - name: BUILDER_IMAGE
           value: $(params.builderImage)