Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] tasks #2007

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

[WIP] tasks #2007

wants to merge 21 commits into from

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: Patch coverage is 89.06606% with 48 lines in your changes missing coverage. Please review.

Project coverage is 65.27%. Comparing base (ff7dca4) to head (3119564).
Report is 281 commits behind head on main.

Files with missing lines Patch % Lines
pkg/pipelines/tekton/resources.go 90.97% 32 Missing and 5 partials ⚠️
pkg/pipelines/tekton/templates.go 59.25% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2007      +/-   ##
==========================================
+ Coverage   63.62%   65.27%   +1.64%     
==========================================
  Files         107      108       +1     
  Lines       13705    13989     +284     
==========================================
+ Hits         8720     9131     +411     
+ Misses       4129     3987     -142     
- Partials      856      871      +15     
Flag Coverage Δ
e2e-test 35.70% <0.45%> (-0.75%) ⬇️
e2e-test-oncluster 31.78% <85.19%> (+1.28%) ⬆️
e2e-test-oncluster-runtime 28.31% <86.78%> (?)
e2e-test-runtime-go 25.07% <0.45%> (?)
e2e-test-runtime-node 26.03% <0.45%> (?)
e2e-test-runtime-python 26.06% <0.45%> (?)
e2e-test-runtime-quarkus 26.18% <0.45%> (?)
e2e-test-runtime-rust 24.99% <0.45%> (?)
e2e-test-runtime-springboot 25.21% <0.45%> (?)
e2e-test-runtime-typescript 26.18% <0.45%> (?)
integration-tests 52.94% <87.47%> (+3.12%) ⬆️
unit-tests-macos-latest 48.26% <30.06%> (-0.50%) ⬇️
unit-tests-ubuntu-latest 49.01% <30.06%> (-0.51%) ⬇️
unit-tests-windows-latest 48.31% <30.06%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2023
@matejvasek matejvasek force-pushed the rework-tasks branch 2 times, most recently from 5751ac9 to 13eb67c Compare October 25, 2023 10:45
Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants