Skip to content

Commit c4b4a19

Browse files
pierDipiknative-prow-robot
authored andcommitted
Unset env.ValueFrom in ImageTransform
When there is an environment variable override for ImageTransform, there could be `ValueFrom` set, in which case the resulting environment field would have both `Value` and `ValueFrom` which is not valid.
1 parent 71d7c8c commit c4b4a19

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

pkg/reconciler/common/images.go

+1
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ func ImageTransform(registry *base.Registry, log *zap.SugaredLogger) mf.Transfor
121121
env := &container.Env[j]
122122
if image, ok := registry.Override[env.Name]; ok {
123123
env.Value = image
124+
env.ValueFrom = nil
124125
}
125126
}
126127
}

0 commit comments

Comments
 (0)