-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does not support JSONC #32
Comments
Thanks for the reminder that tsconfig.json is not really JSON. Not strictly necessary, but if you could provide an example of your configuration that would be helpful. |
Sure thing, the tsconfig.json that I was using is here: https://github.com/IsaacScript/isaacscript/blob/main/packages/isaacscript-common-ts/tsconfig.json |
You want to give #33 a look over? Specifically, I did not add support for |
seems fine, thanks |
Published to npm v1.0.4. |
Hello, and thanks for the package.
I tried it out on my repo and got the following error:
The error message implies that
duel
is parsing the "tsconfig.json" file using JSON. But that is a bug, because "tsconfig.json" files are not JSON files, they are JSONC files. JSONC is a format which allows both comments and trailing commas.You are supposed to parse it with something like the following:
I believe that this is how TypeScript itself parses it, as well as VSCode, and so on.
The text was updated successfully, but these errors were encountered: