Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future development? #8

Open
janpio opened this issue Aug 8, 2017 · 8 comments
Open

Future development? #8

janpio opened this issue Aug 8, 2017 · 8 comments

Comments

@janpio
Copy link
Contributor

janpio commented Aug 8, 2017

Are you planning on any future development of this plugin?
Adding screengrab for Android?
Other Ionic/Cordova specific behaviour?

@knocknarea
Copy link
Owner

@janpio Absolutely. Would you be up to the challenge of adding android screen grab?
Also, while it says that it uses Ionic/Cordova it can also be used with any JS mobile framework that produces an Xcode project

@janpio
Copy link
Contributor Author

janpio commented Aug 9, 2017

I am currently fighting my way through getting screengrab to work with the Cordova Android project. It is painful. Let's see if something comes of it.

@janpio
Copy link
Contributor Author

janpio commented Aug 14, 2017

It's working, so I am looking into how to automate this similar to what you did. I might have some questions and create new issues for them ;)

Re the future development: Did you have any functionality in mind besides the screengrab support for Android? What else is needed to make fastlane work with Ionic/Cordova?

@knocknarea
Copy link
Owner

@janpio Excellent. Welcome on board :-) I would be really good to get it working with android.
I'd like to think it could be used as a one stop shop of ionic/cordova or other javascript framework working with fastlane.

@janpio
Copy link
Contributor Author

janpio commented Aug 14, 2017

That sure would be nice. But what else is missing that is Cordova/Ionic specific?

@brad
Copy link

brad commented Feb 12, 2018

@janpio Do you still have that working screengrab code tucked away somewhere? I could really use it right now

@janpio
Copy link
Contributor Author

janpio commented Feb 12, 2018

I still have these folders and plan to work on it in the future, but this is spread over multiple repositories that were not meant for public, so commit messages are crap (just needed 20 minutes to understand if what I am looking at really is what I thought it was). So I would have to invest a day or two before anyone could actually use it, especially as the newer cordova-android versions have quite a different folder structure :/

If you have specific questions, feel free to ask them as issues at https://github.com/janpio/fastlane-plugin-cordova_screenshots/ (which is the planned fork/repo for these changes)

(Sorry)

@brad
Copy link

brad commented Feb 13, 2018

Thanks for the update @janpio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants