Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected warning for non-initialized relation in body #352

Open
Laschoking opened this issue Sep 13, 2023 · 4 comments
Open

Expected warning for non-initialized relation in body #352

Laschoking opened this issue Sep 13, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request logical logical layer program analysis Issue related to global program analysis
Milestone

Comments

@Laschoking
Copy link

I would expect a warning, if a relation like "nonInitRelation" neither is imported nor appears in the head of any rule.
relation(?a) :- nonInitRelation(?a).

@mmarx mmarx added enhancement New feature or request Parser Rule-Parser-Related Issue logical logical layer labels Sep 13, 2023
@mmarx mmarx added this to nemo Sep 13, 2023
@mmarx mmarx added this to the Release 0.5.0 milestone Sep 13, 2023
@github-project-automation github-project-automation bot moved this to Todo in nemo Sep 13, 2023
@matzemathics
Copy link
Collaborator

@mmarx, I don't think this must necessarily be solved by the parser, because such "global" properties usually will make the parser much more complicated. I think this might should be solved on the same level as type analysis, though I guess there is no rigid architecture in place yet for such checks.

@mmarx
Copy link
Member

mmarx commented Sep 17, 2023

Yeah, probably needs a better tag. Any suggestions?

@matzemathics
Copy link
Collaborator

Yeah, probably needs a better tag. Any suggestions?

something like "Analysis" / "Program Analysis" ?

@mmarx mmarx added program analysis Issue related to global program analysis and removed Parser Rule-Parser-Related Issue labels Sep 17, 2023
@mmarx mmarx modified the milestones: Release 0.5.0, Release 0.6.0 Apr 3, 2024
@monsterkrampe
Copy link
Member

monsterkrampe commented Aug 28, 2024

We need some general functionality to feedback such warnings to the user e.g. via the language server.
Once #455 lands, this will be much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logical logical layer program analysis Issue related to global program analysis
Projects
Status: Todo
Development

No branches or pull requests

5 participants