Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Tracing for Aggregates #469

Closed
Laschoking opened this issue Apr 10, 2024 · 1 comment
Closed

Support Tracing for Aggregates #469

Laschoking opened this issue Apr 10, 2024 · 1 comment
Assignees
@aannleax
Labels
aggregates Issue related to aggregation operations tracing Issue related to tracing of derived facts
Milestone
Release 0.7.0

Comments

@Laschoking
Copy link
Collaborator

Currently tracing an atom that is created through an aggregate results in the following error message:

thread 'main' panicked at nemo-physical/src/tabular/operations/filter.rs:128:9:
internal error: entered unreachable code: Filter must only use markers from the table.

In the future we want to support this case.
@mmarx mmarx added tracing Issue related to tracing of derived facts aggregates Issue related to aggregation operations labels Apr 10, 2024
@mmarx mmarx added this to nemo Apr 10, 2024
@mmarx mmarx added this to the Release 0.6.0 milestone Apr 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in nemo Apr 10, 2024
@monsterkrampe monsterkrampe removed this from the Release 0.6.0 milestone Aug 28, 2024
@aannleax aannleax added this to the Release 0.6.0 milestone Sep 4, 2024
@aannleax
Copy link
Member

The panic is now caught by the parser and we further support min and max aggregates for tracing. For the other aggregates more advanced explanations would be needed.

@github-project-automation github-project-automation bot moved this from Todo to Done in nemo Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aannleax aannleax

Labels
aggregates Issue related to aggregation operations tracing Issue related to tracing of derived facts
Projects
nemo
Archived in project
Milestone
Release 0.7.0
Development

No branches or pull requests
4 participants
@mmarx @monsterkrampe @aannleax @Laschoking